Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: (TEP 0097) debug: breakpoint after,before step execution #7630

Closed
wants to merge 1 commit into from
Closed

WIP: (TEP 0097) debug: breakpoint after,before step execution #7630

wants to merge 1 commit into from

Conversation

waveywaves
Copy link
Member

@waveywaves waveywaves commented Feb 2, 2024 •
edited
Loading

Changes

breakpoint_on_failure runs at the end of a step, this
commit adds a manual breakpoint -breakpoint_after to run after the step ends whether it
fails or not. The checks for this have been added in the same place as breakpoint on failure

breakpoint_before sets a breakpoint before the entrypointer runs the command

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

cc @vdemeester

@tekton-robot tekton-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesnt merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 2, 2024
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign imjasonh after the PR has been reviewed.
You can assign the PR to them by writing /assign @imjasonh in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/pod/entrypoint.go 94.1% 94.2% 0.1

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/pod/entrypoint.go 94.1% 94.2% 0.1

@waveywaves
Copy link
Member Author

/kind tep

@tekton-robot tekton-robot added the kind/tep Categorizes issue or PR as related to a TEP (or needs a TEP). label Feb 2, 2024
@waveywaves
Implement breakpoint_after, breakpoint_before to step entrypoint
e124583 
breakpoint_on_failure runs at the end of a step, this
commit adds a manual breakpoint -breakpoint_after to run after the step ends whether it
fails or not. The checks for this have been added in the same place as breakpoint on failure

breakpoint_before sets a breakpoint before the entrypointer runs the command
@waveywaves waveywaves force-pushed the breakpoint-after-step branch from 121fafa to e124583 Compare February 2, 2024 11:09
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
cmd/entrypoint/main.go 11.6% 11.4% -0.2
pkg/pod/entrypoint.go 94.1% 92.4% -1.7

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
cmd/entrypoint/main.go 11.6% 11.4% -0.2
pkg/pod/entrypoint.go 94.1% 92.4% -1.7

@tekton-robot
Copy link
Collaborator

@waveywaves: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-tekton-pipeline-unit-tests e124583 link true /test pull-tekton-pipeline-unit-tests
pull-tekton-pipeline-build-tests e124583 link true /test pull-tekton-pipeline-build-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@waveywaves waveywaves changed the title WIP: (TEP 0097) debug: breakpoint after step execution WIP: (TEP 0097) debug: breakpoint after,before step execution Feb 2, 2024
@waveywaves waveywaves mentioned this pull request Feb 2, 2024
Merged
@waveywaves waveywaves closed this Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abayer abayer Awaiting requested review from abayer

@pritidesai pritidesai Awaiting requested review from pritidesai

Assignees
No one assigned
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/tep Categorizes issue or PR as related to a TEP (or needs a TEP). release-note-none Denotes a PR that doesnt merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@waveywaves @tekton-robot